Skip to content

Mark vars in AST of ||, &&, if, and unless as generated #15328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnodirlam wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −9
Open

Mark vars in AST of ||, &&, if, and unless as generated #15328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib/elixir/lib/kernel.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,6 +1999,12 @@ defmodule Kernel do
{:case, extra ++ meta, args}
end

defp x_var do
quote generated: true do
x
end
end

defp x_is_false_or_nil do
quote generated: true do
:erlang.orelse(:erlang."=:="(x, false), :erlang."=:="(x, nil))
Expand Down Expand Up @@ -2112,7 +2118,7 @@ defmodule Kernel do
[optimize_boolean: true, type_check: {:case, :!}],
quote do
case unquote(value) do
x when unquote(x_is_false_or_nil()) -> false
unquote(x_var()) when unquote(x_is_false_or_nil()) -> false
_ -> true
end
end
Expand All @@ -2126,7 +2132,7 @@ defmodule Kernel do
[optimize_boolean: true, type_check: {:case, :!}],
quote do
case unquote(value) do
x when unquote(x_is_false_or_nil()) -> true
unquote(x_var()) when unquote(x_is_false_or_nil()) -> true
_ -> false
end
end
Expand Down Expand Up @@ -4055,7 +4061,7 @@ defmodule Kernel do
[optimize_boolean: true, type_check: {:case, :if}],
quote do
case unquote(condition) do
x when unquote(x_is_false_or_nil()) -> unquote(else_clause)
unquote(x_var()) when unquote(x_is_false_or_nil()) -> unquote(else_clause)
_ -> unquote(do_clause)
end
end
Expand Down Expand Up @@ -4107,7 +4113,7 @@ defmodule Kernel do
[optimize_boolean: true, type_check: {:case, :unless}],
quote do
case unquote(condition) do
x when unquote(x_is_false_or_nil()) -> unquote(do_clause)
unquote(x_var()) when unquote(x_is_false_or_nil()) -> unquote(do_clause)
_ -> unquote(else_clause)
end
end
Expand Down Expand Up @@ -4382,8 +4388,8 @@ defmodule Kernel do
[type_check: {:case, :&&}],
quote do
case unquote(left) do
x when unquote(x_is_false_or_nil()) ->
x
unquote(x_var()) when unquote(x_is_false_or_nil()) ->
unquote(x_var())

_ ->
unquote(right)
Expand Down Expand Up @@ -4425,11 +4431,11 @@ defmodule Kernel do
[type_check: {:case, :||}],
quote do
case unquote(left) do
x when unquote(x_is_false_or_nil()) ->
unquote(x_var()) when unquote(x_is_false_or_nil()) ->
unquote(right)

x ->
x
unquote(x_var()) ->
unquote(x_var())
end
end
)
Expand Down