review: ask for a code review now, on a PR or on your working tree#82
Merged
Conversation
Reviews could only be triggered by a push. `agent review 5975` reviews a pull request on demand; a bare `agent review` reviews the work in your tree right now, before there is a PR to review it against. The local path snapshots your working tree, force-pushes it to a sidecar branch (never the branch you are on), and the platform finds-or-creates a draft PR to review it against — a code review is structurally a PR review, so it needs one. Those reviews are terminal-only: nothing is posted to GitHub, findings print in the terminal. A review id IS a session id, so `agent session get <review-id>`, records, and stop all work on it — which is why there is no review-specific status or stream plumbing here. Needs @ellipsis-dev/sdk 0.3.0 for the generated types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI half of the reviews surface. Backend shipped in ellipsis-dev/ellipsis#5980;
@ellipsis-dev/sdk@0.3.0is published, and this bumps to it for the generated types.Reviews could only be triggered by a push. Now:
Aliases:
reviews,code-review,cr.Summary
agent review <pr>blocks and streams the review live, then prints the findings — the findings are collected from the sandbox at teardown, so they only exist once it finalizes. That's the same stream-then-re-GET two-stepagent asset getuses.--no-waitprints the id and exits.agent reviewis the interesting one: it snapshots your working tree (git stash create, so your tree is untouched), force-pushes it toellipsis/review/<your-branch>, and the platform finds-or-creates a draft PR to review it against — a code review is structurally a PR review, so it needs one. Always terminal-only: the PR being reviewed is one the platform manufactured, so commenting on it would be talking to itself.agent session get <review-id>,--watch, records, and stop all work on it unchanged. That's why there's no review-specific status, stream, or cost plumbing here — it reuseswatchSessionStreaming.path:42-48 [4/5 security]with the claim, evidence, and suggested fix indented beneath, highest severity first (the order the platform posts them in). A finding anchored off the diff is labelled recorded-not-posted.Notes for the reviewer
--no-postonly applies to a real PR. The local path hard-codespost: falserather than reading the flag — the first draft threaded the option through and a test caught that--postwould have been honored.reviewreserves the word, soagent review the auth changesdispatches here instead of starting a session with that prompt (the tradeoff every subcommand makes). The error names the fix: quote it.agent reviewon a branch that already has a PR to review that PR incrementally; there's no/v1endpoint to look a PR up by branch, so it always takes the local path. Adding one is a backend follow-up — flagging rather than guessing.Test plan
bun run typecheckcleanbun run test— 318 passed, 20 newbun run buildand the--compilebinary both succeed;agent review --helprenders on the compiled binaryagent review 5975), and that the bare-prompt shorthand still reachessession start🤖 Generated with Claude Code