Skip to content

Intersect user games with public games before loading #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eltoder merged 1 commit into from
Feb 16, 2026
Merged

Intersect user games with public games before loading #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions functions/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,23 +263,38 @@ export const createGame = functions.https.onCall(async (data, context) => {

if (access === "public") {
const oneHourAgo = Date.now() - 3600000;
const recentGameIds = await admin
.database()
.ref(`userGames/${userId}`)
.orderByValue()
.startAt(oneHourAgo)
.once("value");

const recentGames = await Promise.all(
Object.keys(recentGameIds.val() || {}).map((recentGameId) =>
admin.database().ref(`games/${recentGameId}`).once("value")
)
);
const [userGamesSnap, publicGamesSnap] = await Promise.all([
admin
.database()
.ref(`userGames/${userId}`)
.orderByValue()
.startAt(oneHourAgo)
.once("value"),
admin
.database()
.ref("publicGames")
.orderByValue()
.startAt(oneHourAgo)
.once("value"),
]);
const userGamesIds = userGamesSnap.val();
const publicGamesIds = publicGamesSnap.val();
const recentGames =
userGamesIds && publicGamesIds
? await Promise.all(
Object.keys(userGamesIds)
.filter((recentGameId) =>
publicGamesIds.hasOwnProperty(recentGameId)
)
.map((recentGameId) =>
admin.database().ref(`games/${recentGameId}`).once("value")
)
)
: [];

let unfinishedGames = 0;
for (const snap of recentGames) {
if (
snap.child("access").val() === "public" &&
snap.child("status").val() !== "done" &&
snap.child("host").val() === userId
) {
Expand Down