Use browserslist in package.json instead of config/targets.js

[aklkv]

fixes: #282

[mansona]

I have a slight inkling that this should probably be a deprecation if we're going down this route 🤔 essentially we would need to make sure that people transition to the new thing, make decisions about errors that we throw if someone has both (Because of a newly generated file during an ember-cli-update) etc.

thoughts?

[NullVoxPopuli]

a deprecation for something like this could come later tho, if all our tooling already supports the common-since-forever-way-of-doing-things, we can move to that without process (especially since this only affects new or upgrading projects)

make decisions about errors that we throw if someone has both (Because of a newly generated file during an ember-cli-update) etc.

having both isn't a problem tho -- but we can do an eslint check for this -- our default eslint config needs to be concerned with the package.json already (I don't know that it is), but a rule that checks for one or the other can say not to use both (and if we ship that as an optional rule in our lint plugin, we can lump it in the with the RFC for eslint-plugin-ember v14 that we put up yesterday)

[NullVoxPopuli]

Approved, but not merged, because while the blueprint can do what it wants, more or less, it "would be nice", to have a way to tell folks (via eslint-plugin-ember?) that they should ditch their config/targets

[NullVoxPopuli]

If another team member wants to merge this as is, I'm good with that, too

.

[NullVoxPopuli]

From Tooling review, some tasks needed:

• primary thing needed is docs
  • RFC to the blueprint change (can be super tiny -- mostly to track documentation changes)
  • updates / messaging changes in the plugin that reads the targets.js https://github.com/embroider-build/embroider/blob/886a5c99392e2cec7a94ed88a4345a6f81d76d81/packages/vite/src/config-targets.ts#L12

[NullVoxPopuli]

see comment