Handle transient browser disconnections#1515
Open
davidtaylorhq wants to merge 1 commit into
Open
Conversation
Testem fires the `disconnect` event even for temporary drops (e.g. CPU contention) as well as terminal exits. Counting those as browser completions is problematic if all other browsers finish before they reconnect, and causes a 'No moduleQueue was set.' error. This commit drops the `disconnect` listener and instead hooks `runner.finish()`, which fires once per browser when testem definitively gives up. Unforunately testem doesn't expose an event for this, hence the monkey-patch. Fixes ember-cli#370.
davidtaylorhq
added a commit
to discourse/discourse
that referenced
this pull request
May 28, 2026
This handles transient browser detections more gracefully. See upstream ember-cli/ember-exam#1515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testem fires the
disconnectevent even for temporary drops (e.g. CPU contention) as well as terminal exits. Counting those as browser completions is problematic if all other browsers finish before they reconnect, and causes a 'No moduleQueue was set.' error.This commit drops the
disconnectlistener and instead hooksrunner.finish(), which fires once per browser when testem definitively gives up. Unforunately testem doesn't expose an event for this, hence the monkey-patch.Fixes #370.