Fix prettier formatting of ember-cli-build.js generated by blueprint

[Copilot]

Summary

The beta and release CI builds were failing because ember-cli-build.js, generated by ember new using @ember-tooling/classic-build-app-blueprint@6.12.0, has a double blank line before return app.toTree() that prettier now rejects.

Root cause: The blueprint's EJS template produces two consecutive blank lines when warpDrive is enabled (which is the default since --no-ember-data is not passed). This double blank line violates prettier's formatting rules (singleQuote: true config in the generated .prettierrc.js), causing pnpm lint:format to fail.

Changes

In src/markdown/tutorial/part-1/01-orientation.md:

• Added a hidden run:command block after the .prettierignore patch that runs pnpm exec prettier ember-cli-build.js --write to fix the formatting before pnpm test is called
• Added git add ember-cli-build.js to the existing commit block so the formatted file is included in the amended initial commit

[kategengler]

@copilot It fails because prettier is not found

[Copilot]

@copilot It fails because prettier is not found

Fixed in 17fa1f0. The issue was that pnpm exec in a workspace context fails with ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL when running from inside dist/code/super-rentals (which is nested within the tutorial repo that has a pnpm-workspace.yaml). Changed to ./node_modules/.bin/prettier ember-cli-build.js --write to directly invoke the locally-installed prettier binary and bypass pnpm's workspace resolution.

[kategengler]

@copilot This still fails with /bin/sh: 1: ./node_modules/.bin/prettier: not found

[Copilot]

@copilot This still fails with /bin/sh: 1: ./node_modules/.bin/prettier: not found

Fixed in ee8444f. Replaced the prettier invocation with a Node.js one-liner that removes consecutive blank lines directly — no external tool dependency needed:

node -e "const fs=require('fs'),f='ember-cli-build.js';fs.writeFileSync(f,fs.readFileSync(f,'utf8').replace(/\n{3,}/g,'\n\n'));"

Node.js is always available in any Ember project, so this works regardless of what's installed in node_modules.

[kategengler]

@copilot The tutorial now fails on a lint rule: warp-drive/no-external-request-patterns, can you add disable comments to the parts that use fetch directly?

[Copilot]

@copilot The tutorial now fails on a lint rule: warp-drive/no-external-request-patterns, can you add disable comments to the parts that use fetch directly?

Done in 35a7391. Added // eslint-disable-next-line warp-drive/no-external-request-patterns before each direct fetch() call in the tutorial code blocks:

• part-1/08-working-with-data.md — patch that introduces the fetch call in app/routes/index.js (and the follow-up patch that adapts server data)
• part-2/09-route-params.md — file create for app/routes/rental.js
• part-2/11-ember-data.md — both removal patches now also remove the disable comments when the code is replaced with EmberData

[kategengler]

@copilot CI fails with corrupt patch

[Copilot]

@copilot CI fails with corrupt patch

Fixed in 432e8f2. The second patch in 08-working-with-data.md had + // eslint-disable-next-line warp-drive/no-external-request-patterns (adding the comment) but the first patch already added it. The hunk header @@ -2,8 +2,22 @@ was counting it as a context line (8 old lines = 6 context + 2 removed), but the content had a + prefix (giving only 7 old lines). Changed the + prefix to a space so it's a context line, matching the hunk header.

[kategengler]

@copilot This is failing to apply a patch

[Copilot]

@copilot Another corrupt patch.

Fixed in 48767e6. The two patches in chapter 11 had bare empty lines (\n) where unified diff requires space-prefixed context lines ( \n). Specifically:

• Both routes/index.js and routes/rental.js patches had bare blank lines after the new import additions and after + @service store; — these represent lines that stay in the file and must start with a space
• The routes/index.js patch was also missing the class-closing } context line at the end

Both patches now apply cleanly via git apply.

[kategengler]

@copilot Another patch does not apply

[Copilot]

@copilot Another patch does not apply

Fixed in abf4039. The routes/index.js patch in chapter 11 was failing because chapter 9 (09-route-params.md) modifies routes/index.js to add id to the destructuring and return value. The previous e5f17ab commit had incorrectly stripped id from the lines being removed, so the patch was trying to remove let { attributes } = model and return { type, ...attributes } while the actual file had let { id, attributes } = model and return { id, type, ...attributes }. Restored id in both removed lines so the patch matches the actual file state.

[kategengler]

@copilot It is failing on another prettier violation

[Copilot]

@copilot It is failing on another prettier violation

Fixed in b92afeb. The generated app/services/store.js (from the blueprint) also has double blank lines that prettier rejects. Extended the existing node -e fix in chapter 1 to cover both ember-cli-build.js and app/services/store.js, and added git add app/services/store.js to the initial commit block.

[kategengler]

@copilot This is still an issue

[Copilot]

@copilot This is still an issue

Fixed in 627d9a1. The chapter 11 store.js patch was adding JsonSuffixHandler without a trailing comma, which prettier requires for array elements. Changed + JsonSuffixHandler to + JsonSuffixHandler,.

[kategengler]

@copilot Instead of doing that manual manipulation of the files to remove double empty lines, run pnpm lint:fix

[Copilot]

@copilot Instead of doing that manual manipulation of the files to remove double empty lines, run pnpm lint:fix

Done in 5d626c1. Replaced the node -e one-liner with pnpm lint:fix.

[kategengler]

@copilot it complains that concurrently is not found

[Copilot]

@copilot it complains that concurrently is not found

Fixed in cff9037. pnpm lint:fix was running before concurrently was installed. Swapped the order so pnpm i --save-dev concurrently runs first.