Skip to content

Suppress JDK 24 warnings when running java version of closure compiler #26661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Draft

Suppress JDK 24 warnings when running java version of closure compiler #26661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,8 @@ def get_closure_compiler_and_env(user_args):
# This can happen, for example, on arm64 macOS machines that do not have Rosetta installed.
logger.warning('falling back to java version of closure compiler')
user_args.append('--platform=java')
if 'JAVA_TOOL_OPTIONS' not in env:
env['JAVA_TOOL_OPTIONS'] = '--sun-misc-unsafe-memory-access=allow'
check_closure_compiler(closure_cmd, user_args, env, allowed_to_fail=False)

return closure_cmd, env
Expand Down
Loading