Improve CMake support for system libraries - #241
Open
r-burns wants to merge 6 commits into
Open
Conversation
find_package now supports a GLOBAL arg for exporting its targets globally
In some cases (e.g. Tracy), Aurora doesn't even attempt to look for the package, so let's call aurora_find_package_global on these so that system libraries can be picked up. For other packages, I don't have a cmake package config module for them on my system, but I do have usable pkg-config modules for them. Aurora can fall back to pkg-config after a failed find_package call, to see if the libraries can be imported using that method instead.
Snuck in from my local testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use correct target names for find_package imported targets, and use pkg-config as a fallback when possible.