set filter state: add listener filter#43801
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
@wbpcode are you OK co-owning it, just like the other versions of this filter? |
I'm happy to co-own as well. It's super useful for us! |
|
Thanks @agrawroh, added you as well! |
| message Config { | ||
| // A sequence of the filter state values to apply in the specified order | ||
| // when a new connection is received. | ||
| repeated common.set_filter_state.v3.FilterStateValue on_new_connection = 1; |
There was a problem hiding this comment.
nit: may be on_accept ? to clearly show it's used for listener filter? But not a strong point.
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM overall with only one nit comment
/lgtm-any
Yeah. It's fine to me. :) |
…lter Change-Id: I4d4b847cc3f3f5c6ee5eab07c1b04248ac72f5dc
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this great contribution.
4 participants
Commit Message: Add listener filter for set_filter_state. This is useful when there are many filter chains with network set_filter_state, as they all can be collapsed into one instance. Additionally, pull forward listener info metadata setter to make it accessible. This is safe since filter state carries over from listener filters to network filters, and in the special case of re-balancing/original_dst listener, stream info is re-created for the new listener.
Additional Description: Mostly AI generated.
Risk Level: low
Testing: added
Docs Changes: yes
Release Notes: yes