Conversation
Collaborator
|
I like it. Don't know why tests fail, but no need to wait for reviews for such a small change, I'd say. |
Member
Author
|
@paulo-ferraz-oliveira The tests seem to fail consistently. I don't really have the time to trace it down. Do you mind getting this over the line? |
maennchen
force-pushed
the
jm/remove-lodash
branch
from
e5e2646 to
4b5c19e
Compare
NodeJS 24 contains RegExp.escape, no need for lodash.
maennchen
force-pushed
the
jm/remove-lodash
branch
from
7f3de4e to
407b6c3
Compare
Member
Author
|
@paulo-ferraz-oliveira The issue was that there was a regex escape in a URL. This did not matter with lodash that apparently escaped a bit less, but mangled the URL using the built in escaping. On failing tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes lodash. NodeJS 24 contains RegExp.escape, no need for lodash.