fix: sort-keys autofix fully sorts keys in a single pass#235
Draft
crimsonjay0 wants to merge 1 commit into
Draft
fix: sort-keys autofix fully sorts keys in a single pass#235crimsonjay0 wants to merge 1 commit into
crimsonjay0 wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
The
sort-keysautofix previously used a pairwise swap strategy, where each--fixpass only swapped two adjacent out-of-order members. For a fully reversed object with N keys, this required up to N-1 passes ofeslint --fixto reach a fully sorted state.What changes did you make? (Give an overview)
I replaced the pairwise swap fixer with a segment-based sorting approach that fully sorts all keys in a single pass.
Related Issues
Fixes #222
Is there anything you'd like reviewers to focus on?