Skip to content

perf(fill): stream fixture writes, cache pubkeys, and skip redundant BAL hash check, warn on opcode trace failure - #3379

Closed
jochem-brouwer wants to merge 5 commits into
ethereum:forks/amsterdamfrom
jochem-brouwer:test-filler-optimizations
Closed

perf(fill): stream fixture writes, cache pubkeys, and skip redundant BAL hash check, warn on opcode trace failure#3379
jochem-brouwer wants to merge 5 commits into
ethereum:forks/amsterdamfrom
jochem-brouwer:test-filler-optimizations

Conversation

@jochem-brouwer

Copy link
Copy Markdown
Member

Description

This PR contains 4 commits to optimize/warnings some parts of the filler process:

  • don't verify the BAL hash against itself
  • stream fixture writes
  • ensure pubkey isn't calculated twice
  • warn and discard a partial opcode trace

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie added A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-feat Category: an improvement or new feature C-perf Scope: Performance - an optimization or speed-up. and removed C-feat Category: an improvement or new feature labels Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (ce0509a) to head (d7b1b4a).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3379   +/-   ##
================================================
  Coverage            93.53%   93.53%           
================================================
  Files                  624      624           
  Lines                37074    37074           
  Branches              3394     3394           
================================================
  Hits                 34679    34679           
  Misses                1645     1645           
  Partials               750      750           
Flag Coverage Δ
unittests 93.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisTsai-Csie
LouisTsai-Csie force-pushed the test-filler-optimizations branch from 5cc9110 to d7b1b4a Compare August 20, 2026 10:21
@jochem-brouwer

Copy link
Copy Markdown
Member Author

Split up in #3429, #3430, #3431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-perf Scope: Performance - an optimization or speed-up.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants