feat(specs,test-specs,tests): Update Engine API to latest Bogota spec, implement IL inclusion_test - #3401
Open
marioevz wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7805 #3401 +/- ##
==========================================================
Coverage ? 81.95%
==========================================================
Files ? 624
Lines ? 37099
Branches ? 3397
==========================================================
Hits ? 30405
Misses ? 6274
Partials ? 420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
self-requested a review
August 20, 2026 09:48
spencer-tb
approved these changes
Aug 20, 2026
Contributor
There was a problem hiding this comment.
The t8n requires inclusion lists whenever the spec module tracks inclusion_list_satisfied, and amsterdam shares that module with bogota, so every amsterdam fill crashes.
Fixes for this: spencer-tb/execution-specs@ca86b6e...pr-3401-il-fill-fix, feel free to cherry pick...
What each commit does:
- fixes amsterdam fill CI, spencer-tb@470da9ec70
inclusionListSatisfiedomitted from fixtures on non VALID payloads, match engine api spec, spencer-tb@f7599f602f- test_collect_only count 3 to 4, CI fix, also in spencer-tb@f7599f602f
- IL variant is generated only for
blockchain_test_engine+engine_x, not sync and stateful, spencer-tb@5931b9b5cc - empty last block and block level only exceptions now fail with a clear "test correctness" error instead of an IndexError, spencer-tb@dd4d467e7b
decode_transactionno longer crashes the IL validator on empty bytes or first byte 0xff, spencer-tb@c9d3dedd78- drop the stale "blob transactions are excluded" sentence from the IL check docstring, spencer-tb@aa341bd2ec
Draft
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #3373, with the following improvements:
Update to latest Engine API spec
Updates to the latest engine/bogota.md, which includes using
engine_newPayloadV6andengine_forkchoiceUpdatedV5.Each blockchain engine fixture now contains an
inclusionListSatisfiedfield in each payload with the expected response for thePayloadStatusV2field from anengine_newPayloadV6request to a client, and replaces theINCLUSION_LIST_UNSATISFIEDpayload-status enum value expected in previous fixture formats.Inclusion List Variant for
inclusion_testMarked TestsAll blockchain and state tests from previous forks that were marked in #3337 now automatically generate an inclusion-list variant test where the last transaction of the last block is moved from the block to the inclusion list, with two different expectations:
Three bugs were found in the spec with these newly generated tests.
Spec Fixes
Spec bugs caught and fixed by tests mentioned in previous section:
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture