chore(tests): add genesis block header field BAL checklist - #3416
Conversation
43fe293 to
2897bb6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3416 +/- ##
===================================================
+ Coverage 93.53% 93.77% +0.23%
===================================================
Files 624 624
Lines 37074 36905 -169
Branches 3394 3326 -68
===================================================
- Hits 34679 34606 -73
+ Misses 1645 1597 -48
+ Partials 750 702 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
left a comment
There was a problem hiding this comment.
The BlockHeaderField.Test.Genesis item is indeed unmarked for 7928, although a dedicated test doesn't get us extra coverage here.
The genesis BAL is always empty, so every valid_from("Amsterdam") fixture already carries the only valid value. Could you instead, drop test_bal_genesis and add @EIPChecklist.BlockHeaderField.Test.Genesis() to test_bal_nonce_changes. And then also revert the missed_lines change in eip_checklist_external_coverage.txt?
It should just be a one line change!
2897bb6 to
3cf1947
Compare
Summary
test_bal_genesisfor EIP-7928, covering the remaining checklist itemblock_header_field/test/genesiseip_checklist_external_coverage.txtforgeneral/code_coverage/missed_linesFollows the same pattern as
test_slotnum_genesisin EIP-7843.Test plan
uv run fill tests/amsterdam/eip7928_block_level_access_lists/test_fork_transition.py::test_bal_genesis --until=Amsterdam --cleanChecklist
just static<type>(<area>): <title>Cute Animal Picture
Glamsterdam polar bear 🐻❄️