Skip to content

chore(tests): add genesis block header field BAL checklist - #3416

Merged
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
shubham5080:test/eip7928-bal-genesis
Aug 26, 2026
Merged

chore(tests): add genesis block header field BAL checklist#3416
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
shubham5080:test/eip7928-bal-genesis

Conversation

@shubham5080

@shubham5080 shubham5080 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add test_bal_genesis for EIP-7928, covering the remaining checklist item block_header_field/test/genesis
  • Genesis header must carry the empty BAL hash; block 1 verifies transfer activity is recorded in the BAL body
  • Update eip_checklist_external_coverage.txt for general/code_coverage/missed_lines

Follows the same pattern as test_slotnum_genesis in EIP-7843.

Test plan

  • uv run fill tests/amsterdam/eip7928_block_level_access_lists/test_fork_transition.py::test_bal_genesis --until=Amsterdam --clean

Checklist

  • Ran fast static checks to avoid CI fails: just static
  • PR title has the form <type>(<area>): <title>

Cute Animal Picture

Glamsterdam polar bear 🐻‍❄️

polar bear

@shubham5080
shubham5080 force-pushed the test/eip7928-bal-genesis branch from 43fe293 to 2897bb6 Compare August 22, 2026 10:08
@spencer-tb spencer-tb added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels Aug 22, 2026
@spencer-tb spencer-tb changed the title test(eip7928): add genesis block header field test for BAL hash feat(tests): add genesis block header field test for BAL hash Aug 22, 2026
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.77%. Comparing base (ac0bf4f) to head (3cf1947).
⚠️ Report is 13 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3416      +/-   ##
===================================================
+ Coverage            93.53%   93.77%   +0.23%     
===================================================
  Files                  624      624              
  Lines                37074    36905     -169     
  Branches              3394     3326      -68     
===================================================
- Hits                 34679    34606      -73     
+ Misses                1645     1597      -48     
+ Partials               750      702      -48     
Flag Coverage Δ
unittests 93.77% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BlockHeaderField.Test.Genesis item is indeed unmarked for 7928, although a dedicated test doesn't get us extra coverage here.

The genesis BAL is always empty, so every valid_from("Amsterdam") fixture already carries the only valid value. Could you instead, drop test_bal_genesis and add @EIPChecklist.BlockHeaderField.Test.Genesis() to test_bal_nonce_changes. And then also revert the missed_lines change in eip_checklist_external_coverage.txt?

It should just be a one line change!

@spencer-tb
spencer-tb force-pushed the test/eip7928-bal-genesis branch from 2897bb6 to 3cf1947 Compare August 26, 2026 10:11
@spencer-tb spencer-tb changed the title feat(tests): add genesis block header field test for BAL hash chore(tests): add genesis block header field BAL checklist Aug 26, 2026
@spencer-tb
spencer-tb merged commit e221d0c into ethereum:forks/amsterdam Aug 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants