yash/feat/permissionless-execute-task#384
Merged
pankajjagtapp merged 1 commit intopankaj/feat/security-upgradesfrom Apr 29, 2026
Merged
yash/feat/permissionless-execute-task#384pankajjagtapp merged 1 commit intopankaj/feat/security-upgradesfrom
pankajjagtapp merged 1 commit intopankaj/feat/security-upgradesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Removes role gating from
EtherFiAdmin.executeTasks, allowing any account to trigger state-changing reward/fee/validator/withdrawal processing once oracle consensus and sequencing/freshness checks pass. This increases operational exposure (griefing/DoS via public callers) and should be reviewed for reentrancy, gas, and trust assumptions around report validity.Overview
EtherFiAdmin.executeTasksis now permissionless: the executor role check was removed so any caller can process an oracle report once consensus is reached and the report passes the existing sequencing (refSlotFrom/refBlockFrom) and freshness wait checks.Tests were updated to reflect this behavior by renaming the insufficient-role test to
test_executeTasks_permissionlessand asserting a role-less address can execute tasks and advancelastHandledReportRefSlot/lastHandledReportRefBlock.Reviewed by Cursor Bugbot for commit 41a05fa. Bugbot is set up for automated code reviews on this repo. Configure here.