Open
Conversation
yorickdowne
force-pushed
the
refactor-config
branch
21 times, most recently
from
60d129c to
9f97c12
Compare
yorickdowne
force-pushed
the
refactor-config
branch
from
9f97c12 to
7175d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Refactor
ethd configto make it easier to follow the config workflow for a specific deployment type. This also cleans up the code that was contributed by Lido.In
default.env,COMPOSE_FILEis now a composite ofCUSTOM_FILESandCORE_FILES.ethd configonly ever touchesCORE_FILES. The intent is to allow users that use Siren, Contributoor, &c, to runethd configand not lose their editsconfig()calls__config_${__deployment}. This does make the code less DRY, but far easier to read for me.__write_varsis an array that has all of the variables that need to be written to.envat the end. The__config_xxand__query_xxfunctions add to it.__query_mev()had extensive changes, to handle Lido MEV and non-Lido MEV broadly the same way, UX-wisequery functions have been changed to use the newer
choices+=()patternTested all
./ethd configcode paths that I could think of, documented intestsLido Obol can't be fully tested by me, as it requires an actual live Obol cluster during
ethd config