fix: derive __version__ from package metadata - #14
Open
haeter525 wants to merge 1 commit into
Open
Conversation
Read the version from importlib.metadata so pyproject.toml is the single source of truth. Previously __version__ was a hardcoded literal that drifted from pyproject.toml, causing `dextrace -V` to report a stale version. Fixes #13 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
Problem
__version__was a hardcoded literal insrc/dextrace/version.pythat drifted frompyproject.toml. In26.6.1,pip show dextracereported26.6.1whiledextrace -VprintedDexTrace 25.10.1.Fix
Read the version from
importlib.metadatasopyproject.tomlis the single source of truth:Verification
pip install -e .thendextrace -V→DexTrace 26.6.1(matchespip show)importlib.metadatais stdlib (Python ≥3.8)Note
This corrects the CLI version for the next release. PyPI is immutable, so the already-published
26.6.1keeps reporting25.10.1; the fix takes effect when a26.6.2is cut.🤖 Generated with Claude Code