Add project name and version context to SBOM file name - #948
Open
Rimsha2535 wants to merge 8 commits into
Open
Conversation
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 08:39 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 08:39 — with
GitHub Actions
Waiting
12 tasks
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 08:48 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 08:48 — with
GitHub Actions
Waiting
ArBridgeman
reviewed
Aug 11, 2026
ArBridgeman
reviewed
Aug 11, 2026
|
|
||
|
|
||
| @poetry_command | ||
| def project_name_and_version_from_poetry( |
Collaborator
There was a problem hiding this comment.
Let's move this function into exasol.toolbox.util.version. That way if another command needs it later, it's easy to find.
ArBridgeman
reviewed
Aug 11, 2026
ArBridgeman
reviewed
Aug 11, 2026
ArBridgeman
reviewed
Aug 11, 2026
ArBridgeman
reviewed
Aug 11, 2026
| - name: Rename SBOM | ||
| id: rename-sbom | ||
| run: | | ||
| SBOM_NAME=$(poetry version --no-ansi | awk '{gsub(/-/, "_", $1); print $1"-"$2".spdx.json"}') |
Collaborator
There was a problem hiding this comment.
Not a bad idea. Maybe instead of regenerating the name, we can set it when the nox session is executed.
@nox.session(name="dependency:sbom", python=False)
def generate_sbom(session: Session) -> None:
"""Generate SPDX SBOM for the project dependencies.
Note: SPDX version 2 is used as no stable Python tool exists yet
for generating SPDX version 3.
"""
project_name, version = project_name_and_version_from_poetry(
working_directory=PROJECT_CONFIG.root_path
)
sbom_filename = f"{project_name}-{version}.spdx.json"
bom_cdx_json = PROJECT_CONFIG.root_path / "bom.cdx.json"
bom_spdx_json = PROJECT_CONFIG.root_path / sbom_filename
session.run("cyclonedx-py", "environment", "-o", bom_cdx_json)
session.run(
"sbomconvert",
"-i",
bom_cdx_json,
"--sbom",
"spdx",
"--format",
"json",
"-o",
bom_spdx_json,
)
session.run("test", "-s", bom_spdx_json)
print(sbom_filename) - name: Generate SBOM
id: generate-sbom
run: |
SBOM_NAME="$(poetry run -- nox -s dependency:sbom)"
echo "SBOM_NAME=$SBOM_NAME" >> "$GITHUB_OUTPUT"Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:10 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:10 — with
GitHub Actions
Waiting
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:11 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:11 — with
GitHub Actions
Waiting
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:11 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:11 — with
GitHub Actions
Waiting
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:12 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 12:12 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 17:15 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 17:15 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 17:29 — with
GitHub Actions
Waiting
Rimsha2535
requested a deployment
to
manual-approval
August 11, 2026 17:29 — with
GitHub Actions
Waiting
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #946
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: