Skip to content

Sync strain tests#1609

Merged
SleeplessByte merged 5 commits intoexercism:mainfrom
BNAndras:sync-strain
Feb 15, 2026
Merged

Sync strain tests#1609
SleeplessByte merged 5 commits intoexercism:mainfrom
BNAndras:sync-strain

Conversation

@BNAndras
Copy link
Member

@BNAndras BNAndras commented Jan 8, 2026

Related to #1597. Mark as tiny.

The test suite uses slightly different functions so I updated those to match what's happening in the problem specifications. There shouldn't be any meaningful differences there. I also changed the words to be an array literal so it's a little clearer what's actually being compared before and after. That included a minor typo fix. Finally, I added two missing tests for keeps nothing and discards nothing

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BNAndras
Copy link
Member Author

BNAndras commented Jan 8, 2026

Hmm, I thought defining the predicates outside the function call like we did over in Accumulate would fix the @typescript-eslint/no-unused-vars error.

@SleeplessByte
Copy link
Member

Hmm, I thought defining the predicates outside the function call like we did over in Accumulate would fix the @typescript-eslint/no-unused-vars error.

Nah, I set it up that we must prefix with _. I want us to be explicit about unused variables!

@SleeplessByte SleeplessByte added x:size/small Small amount of work x:action/sync Sync content with its latest version labels Feb 15, 2026
@SleeplessByte SleeplessByte merged commit b3363f1 into exercism:main Feb 15, 2026
8 checks passed
@BNAndras BNAndras deleted the sync-strain branch February 15, 2026 22:18
@BNAndras
Copy link
Member Author

Makes sense. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants