[eas-cli] Add eas update:upload-embedded command#3699
Closed
gwdp wants to merge 2 commits into
Closed
Conversation
3c8e644 to
7a40d10
Compare
|
✅ Thank you for adding the changelog entry! |
Contributor
Author
|
Superseded by #3720 which has the corrected implementation (removed channelId lookup and launchAssetStorageKey, stacked with view-embedded and list-embedded). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EAS Update bundle diffing can't generate patches against the JS bundle embedded in a native build, so the first OTA after install always downloads the full bundle. This command registers the embedded bundle with EAS Update so the diff worker can use it as a patch base.
Ref ENG-21033
How
eas update:upload-embeddedcommand with--platform,--bundle,--manifest,--channel, and optional--build-id/--jsonflagsapp.manifestto extract the embedded update UUID and validates itruntimeVersionvia the same helpereas updateusesgetSignedEmbeddedUpdateAssetUploadSpecifications, uploads the bundleuploadEmbeddedUpdatewith the storage key + manifest fieldsEMBEDDED_UPDATE_ASSET_NOT_READY(GCS finalization race) with exponential backoff; exits immediately onEMBEDDED_UPDATE_CONFLICTTest Plan
yarn jest src/commands/update/__tests__/upload-embedded.test.ts src/graphql/mutations/__tests__/EmbeddedUpdateMutation-test.ts— 31 tests passyarn tsc && yarn lintpass