[cocoapods-proxy] Proxy requests to central.sonatype.com too#3736
Open
sjchmiela wants to merge 1 commit into
Open
[cocoapods-proxy] Proxy requests to central.sonatype.com too#3736sjchmiela wants to merge 1 commit into
sjchmiela wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 901 901
Lines 38979 38979
Branches 8107 8107
=======================================
Hits 22047 22047
Misses 16825 16825
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
central.sonatype.comsupport to the packagedexpo-cocoapods-proxygem used by iOS workers.Change
central.sonatype.comto thePod::Downloader::Httpproxy allowlist.Code Requiring This
This PR is for CocoaPods
:httppod source downloads. It does not proxy React Native'sNet::HTTPmetadata lookup.React Native returns Sonatype artifact URLs to CocoaPods as
:httppod sources here:{:http => url}after resolving the Sonatype nightly artifact URL: https://github.com/facebook/react-native/blob/7bbb13c9be014c0e63f0deaad809d669c15325ad/packages/react-native/scripts/cocoapods/rncore.rb#L170-L173{:http => url}after resolving the Sonatype nightly artifact URL: https://github.com/facebook/react-native/blob/7bbb13c9be014c0e63f0deaad809d669c15325ad/packages/react-native/scripts/cocoapods/rndependencies.rb#L205-L208{:http => url}after resolving the Sonatype nightly artifact URL: https://github.com/facebook/react-native/blob/7bbb13c9be014c0e63f0deaad809d669c15325ad/packages/react-native/sdks/hermes-engine/hermes-utils.rb#L190-L193CocoaPods/cocoapods-downloader then uses
Pod::Downloader::Httpfor those:httpparams:Downloader.for_target(...).download: https://github.com/CocoaPods/CocoaPods/blob/1.12.1/lib/cocoapods/downloader.rb#L107-L110cocoapods-downloadermaps:httptoHttp: https://github.com/CocoaPods/cocoapods-downloader/blob/1.6.3/lib/cocoapods-downloader.rb#L22-L30Downloader.for_targetinstantiates that downloader with the:httpURL: https://github.com/CocoaPods/cocoapods-downloader/blob/1.6.3/lib/cocoapods-downloader.rb#L51-L64Pod::Downloader::Http#download_fileuses curl for that URL: https://github.com/CocoaPods/cocoapods-downloader/blob/1.6.3/lib/cocoapods-downloader/http.rb#L12-L22Validation
rspecinpackages/expo-cocoapods-proxy: 16 examples, 0 failuresgit diff --check