[build-tools] Support absolute artifact glob paths#3738
Open
sjchmiela wants to merge 1 commit into
Open
Conversation
sjchmiela
changed the title
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3738 +/- ##
=======================================
Coverage 56.62% 56.62%
=======================================
Files 906 906
Lines 39063 39063
Branches 8158 8159 +1
=======================================
Hits 22117 22117
Misses 15468 15468
Partials 1478 1478 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates artifact path resolution so absolute paths containing glob metacharacters are treated as glob patterns instead of literal paths.
This lets
eas/upload_artifacthandle paths like/var/folders/.../T/maestro_xctestrunner_xcodebuild_output*, while preserving the existing literal-path behavior for non-dynamic absolute paths.Why
upload_artifact.pathalready accepts paths or patterns, but absolute patterns were previously short-circuited throughfs.pathExists()and never reachedfast-glob.Test Plan
yarn workspace @expo/build-tools jest-unit packages/build-tools/src/utils/__tests__/artifacts.test.tsNote: the focused test was run in the existing local checkout with the same two-file patch. The clean PR worktree did not have its own install state.