[eas-cli] Add --max-idle-time-minutes flag to eas simulator - #4156
[eas-cli] Add --max-idle-time-minutes flag to eas simulator#4156szdziedzic wants to merge 2 commits into
Conversation
5d7a255 to
95419a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
==========================================
+ Coverage 62.98% 62.98% +0.01%
==========================================
Files 1020 1020
Lines 46382 46385 +3
Branches 9787 9788 +1
==========================================
+ Hits 29208 29211 +3
Misses 15717 15717
Partials 1457 1457 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
95419a1 to
e933995
Compare
🤖 AI code reviewDecision: Approve Overall PR risk: Low. The change is additive: it adds one optional No findings. This review is advisory — it never blocks a merge and never auto-approves. |
9ced7ee to
e933995
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
e933995 to
bca121e
Compare
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Why
EAS Simulator sessions cost money while they run. Today a session that nobody uses keeps running until its max duration. This PR adds the CLI half of an opt-in idle timeout: the user sets it when starting the session, and EAS stops the session after that many minutes without activity.
Related PRs:
maxIdleTimeMinutesand passes themax_idle_time_minutesstep input)How
Add new
--max-idle-time-minutesinteger flag. It is passed asmaxIdleTimeMinutesonCreateDeviceRunSessionInput.Test Plan
CI passes