Skip to content

[eas-cli] Add --max-idle-time-minutes flag to eas simulator - #4156

Open
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2
Open

[eas-cli] Add --max-idle-time-minutes flag to eas simulator#4156
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Why

EAS Simulator sessions cost money while they run. Today a session that nobody uses keeps running until its max duration. This PR adds the CLI half of an opt-in idle timeout: the user sets it when starting the session, and EAS stops the session after that many minutes without activity.

Related PRs:

How

Add new --max-idle-time-minutes integer flag. It is passed as maxIdleTimeMinutes on CreateDeviceRunSessionInput.

Test Plan

CI passes

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from 5d7a255 to 95419a1 Compare August 5, 2026 18:18
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.98%. Comparing base (1ec9e83) to head (bca121e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4156      +/-   ##
==========================================
+ Coverage   62.98%   62.98%   +0.01%     
==========================================
  Files        1020     1020              
  Lines       46382    46385       +3     
  Branches     9787     9788       +1     
==========================================
+ Hits        29208    29211       +3     
  Misses      15717    15717              
  Partials     1457     1457              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from 95419a1 to e933995 Compare August 5, 2026 21:22
@szdziedzic szdziedzic changed the title [eas-cli][build-tools] Add opt-in max idle time for EAS Simulator sessions [eas-cli] Add --max-idle-time-minutes flag to eas simulator Aug 5, 2026
@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

Overall PR risk: Low. The change is additive: it adds one optional --max-idle-time-minutes flag to the eas simulator command and forwards it as maxIdleTimeMinutes in the existing createDeviceRunSession mutation input. When the user omits the flag, the request keeps its previous shape, so existing sessions are not affected. No reviewer reported a critical or warning finding; the eas simulator command stays hidden and experimental, and the blast radius is small, with an easy rollback by reverting the flag and mutation field.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch 2 times, most recently from 9ced7ee to e933995 Compare August 5, 2026 21:52
@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/eas-simulator-idle-timeout-2c8cf2 branch from e933995 to bca121e Compare August 11, 2026 10:56
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@szdziedzic
szdziedzic marked this pull request as ready for review August 11, 2026 11:07
@szdziedzic
szdziedzic requested a review from sjchmiela August 11, 2026 11:07
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants