[steps] Composite functions: skip the outputs step when the call never ran - #4207
Merged
sswrk merged 2 commits intoAug 17, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
+ Coverage 63.52% 63.53% +0.02%
==========================================
Files 1028 1028
Lines 46918 46938 +20
Branches 9847 9852 +5
==========================================
+ Hits 29801 29819 +18
- Misses 17015 17017 +2
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sswrk
marked this pull request as ready for review
August 14, 2026 18:20
hSATAC
approved these changes
Aug 17, 2026
… when a nested call has no outputs
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
sswrk
deleted the
szymonswierk/eng-25537-exposteps-skipped-composite-function-call-reports-success
branch
August 17, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In this comment #4062 (comment) it was brought up that when no steps of a composite function run (because an earlier step has failed) and the caller sets
if: ${{ always() }}, the synthetic "outputs" step runs anyway.The expected behavior is that the synthetic "outputs" step is skipped too.
How
In CompositeBuildStep,
shouldExecuteStepis overridden so the outputs step runs ifrunByDefaultis true or any authored child has run.Test Plan
Added unit tests.