postinstall command put in package.json #17183
Open
+51
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postinstall command is added in package.json to excute scripts/postinstall.sh , it executes shell script called postinstall.sh to do backup as original package.json as npm audit fix --force updates the user written package.json and there is no backup of package.json currently done , Thus original package.json gets lost , unless the Project is git maintained , and npm audit fix --force can be reversed by developer , and user may want to restore his original package.json .
this creates a backup of original package.json at the time of "npm install" itself , this is tested with same modification to create-react-app new sample project, however react team can review the need to echo and take backup of package.json file postinstall.sh needs to be put in scripts folder in the project