Fixes in build files to allow a smooth macOS build#598
Open
hpnkv wants to merge 3 commits intofacebook:mainfrom
Open
Fixes in build files to allow a smooth macOS build#598hpnkv wants to merge 3 commits intofacebook:mainfrom
hpnkv wants to merge 3 commits intofacebook:mainfrom
Conversation
Fizz examples' CMakeLists.txt do not link Folly, so Proxygen builds fail, at least on macOS. With `-DBUILD_EXAMPLES=OFF`, the build succeeds.
…min CMake policy version 3.10 for zstd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes fix two issues:
build.shdue to 1) incorrectgoogletestfolder name in dependencies, 2) absence of a Folly link in Fizz examples, 3) hard failure ofzstdwith newer CMake versions due to policy version enforcement,c-areslink that propagates to consumer projects.As a result, on macOS, the project itself can successfully build via
./build.sh, and can be successfully linked as a dependency.I did notice one of the previous commits that does the opposite to
c-aresin CMakeLists.txt—so I'm being careful by switching the change only byif (APPLE).