Skip to content

Conversation

@begoon
Copy link

@begoon begoon commented Jan 4, 2026

Summary

The PR adds "-q/--quiet" flag for "check".

Fixes #2000

Test Plan

With "-q" or "--quiet" flag, "check" command does not print anything if there is no errors found.

@meta-cla
Copy link

meta-cla bot commented Jan 4, 2026

Hi @begoon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@begoon
Copy link
Author

begoon commented Jan 4, 2026

python3 test.py

created no new files.

@begoon
Copy link
Author

begoon commented Jan 4, 2026

CLA is signed.

@meta-cla
Copy link

meta-cla bot commented Jan 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Jan 4, 2026
@yangdanny97
Copy link
Contributor

Could you please add a test case here? https://github.com/facebook/pyrefly/blob/main/test/args.md

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas)
- ::error file=pandas/core/indexing.py,line=1470,col=9,endLine=1470,endColumn=28,title=Pyrefly bad-override::Class member `_LocIndexer._convert_to_indexer` overrides parent class `_LocationIndexer` in an inconsistent manner%0A  `_LocIndexer._convert_to_indexer` has type `BoundMethod[_LocIndexer, (self: _LocIndexer, key: Unknown, axis: int) -> int | ndarray[tuple[int], dtype[Any]] | ndarray[tuple[Any, ...], dtype[signedinteger[_NBitIntP]]] | ndarray[tuple[Any, ...], dtype[Any]] | slice[int, int, Any] | slice[Any, Any, Any] | dict[str, int | integer[Any]] | dict[str, tuple[Unknown, ...]] | dict[str, Unknown] | Unknown]`, which is not assignable to `BoundMethod[_LocIndexer, (self: _LocIndexer, key: Unknown, axis: int) -> Never]`, the type of `_LocationIndexer._convert_to_indexer`
+ ::error file=pandas/core/indexing.py,line=1470,col=9,endLine=1470,endColumn=28,title=Pyrefly bad-override::Class member `_LocIndexer._convert_to_indexer` overrides parent class `_LocationIndexer` in an inconsistent manner%0A  `_LocIndexer._convert_to_indexer` has type `BoundMethod[_LocIndexer, (self: _LocIndexer, key: Unknown, axis: int) -> ndarray[tuple[Any, ...], dtype[signedinteger[_NBitIntP]]] | ndarray[tuple[Any, ...], dtype[Any]] | dict[str, int | integer[Any]] | dict[str, tuple[Unknown, ...]] | dict[str, Unknown] | Unknown]`, which is not assignable to `BoundMethod[_LocIndexer, (self: _LocIndexer, key: Unknown, axis: int) -> Never]`, the type of `_LocationIndexer._convert_to_indexer`

@begoon
Copy link
Author

begoon commented Jan 5, 2026

Could you please add a test case here? main/test/args.md

@yangdanny97 Added

@rchen152
Copy link
Contributor

rchen152 commented Jan 5, 2026

Just want to flag that there's some ongoing discussion here about the best way to implement this: #2000.

@rchen152 rchen152 added needs-discussion An issue where it's not clear whether there is a bug or we are behaving as expected. and removed needs-triage labels Jan 8, 2026
@stroxler
Copy link
Contributor

stroxler commented Jan 9, 2026

FYI: assigning #2000 + this PR to @rchen152 since the discussion on how to best implement and the PR review are connected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed needs-discussion An issue where it's not clear whether there is a bug or we are behaving as expected. needs-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--quiet/-q flag to silence non-error output

4 participants