Remove redundant pieces of the IGNORE_COMMENT_REGEX#4226
Open
oprypin wants to merge 1 commit into
Open
Conversation
This is a no-op refactor. Each branch of this regex contains a copy of the construct `\s*(?:;\s*)?[^#]*`, but the last part of it already covers everything that the other parts could possibly cover, so we remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a no-op refactor.
Each branch of this regex contains a copy of the construct
\s*(?:;\s*)?[^#]*, but the last part of it already covers everything that the other parts could possibly cover, so we remove them.Test Plan
No functionality is changed, so if all preexisting tests pass, that should be sufficient.
And in my brief manual usage of
pyrefly suppressI didn't encounter any issues.