Exclude privately-named classes from pyrefly coverage#4249
Closed
jorenham wants to merge 1 commit into
Closed
Conversation
jorenham
added
the
coverage
jorenham
force-pushed
the
coverage/exclude-private-classes
branch
from
July 22, 2026 15:15
b75b6ad to
14196aa
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@samwgoldman has imported this pull request. If you are a Meta employee, you can view this in D113438823. |
stroxler
approved these changes
Jul 23, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
@samwgoldman merged this pull request in cb5057b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Privately-named functions, variables, methods, and attrs were already excluded, but privately-named classes weren't, so e.g.
_Foo.barwas still reported.A private name now hides its whole subtree unless exported via
__all__, consistent with the other symbol kinds and with the documented behavior.Test Plan
Regression tests added.