Don't requalify already globally qualified identifiers#55847
Open
j-piasecki wants to merge 6 commits intofacebook:mainfrom
Open
Don't requalify already globally qualified identifiers#55847j-piasecki wants to merge 6 commits intofacebook:mainfrom
j-piasecki wants to merge 6 commits intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] Updates the C++ API snapshot generator so that it tries to read doxygen binary location from the env variable before falling back to relying on PATH. Differential Revision: D94901517
Summary: Changelog: [Internal] Adds explicit support for friend classes in the C++ API snapshot. Doxygen treats friends as variables of type "friend". For the snapshot use case, we cover that special case and store them as explicit `FriendMember`. This allows for correctly ignoring friend definitions when qualifying identifiers. Differential Revision: D94901510
Summary: Changelog: [Internal] Updates the C++ API snapshot generator not to include anonymous namespaces in the snapshot since those have internal linkage. Differential Revision: D94901508
Summary: Changelog: [Internal] Updates C++ API snapshot generator not to include anonymous variables in the snapshot. This covers an edge case where doxygen will generate an anonymout member of type "union" when an anonymous union is present in a class. Differential Revision: D94901506
Summary: Changelog: [Internal] When constructors are marked as "constexpr", doxygen will output them as a function of type "constexpr" with "is-constexpr=yes". This causes the script to duplicate the keyword. This diff fixes that by explicitly covering this edge case. Differential Revision: D94901507
Summary: Changelog: [Internal] Disables name qualification on already globally qualified identifiers. Differential Revision: D94901503
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94901503. |
cortinico
approved these changes
Mar 2, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Disables name qualification on already globally qualified identifiers.
Differential Revision: D94901503