Skip to content

Unmangle templates in doxygen output#55848

Closed
j-piasecki wants to merge 7 commits intofacebook:mainfrom
j-piasecki:export-D94901504
Closed

Unmangle templates in doxygen output#55848
j-piasecki wants to merge 7 commits intofacebook:mainfrom
j-piasecki:export-D94901504

Conversation

@j-piasecki
Copy link
Contributor

Summary:
Changelog: [Internal]

Updates doxygen refid resolver to unmangle the template arguments.

Differential Revision: D94901504

Summary:
Changelog: [Internal]

Updates the C++ API snapshot generator so that it tries to read doxygen binary location from the env variable before falling back to relying on PATH.

Differential Revision: D94901517
Summary:
Changelog: [Internal]

Adds explicit support for friend classes in the C++ API snapshot. Doxygen treats friends as variables of type "friend". For the snapshot use case, we cover that special case and store them as explicit `FriendMember`. This allows for correctly ignoring friend definitions when qualifying identifiers.

Differential Revision: D94901510
Summary:
Changelog: [Internal]

Updates the C++ API snapshot generator not to include anonymous namespaces in the snapshot since those have internal linkage.

Differential Revision: D94901508
Summary:
Changelog: [Internal]

Updates C++ API snapshot generator not to include anonymous variables in the snapshot.

This covers an edge case where doxygen will generate an anonymout member of type "union" when an anonymous union is present in a class.

Differential Revision: D94901506
Summary:
Changelog: [Internal]

When constructors are marked as "constexpr", doxygen will output them as a function of type "constexpr" with "is-constexpr=yes". This causes the script to duplicate the keyword.

This diff fixes that by explicitly covering this edge case.

Differential Revision: D94901507
Summary:
Changelog: [Internal]

Disables name qualification on already globally qualified identifiers.

Differential Revision: D94901503
Summary:
Changelog: [Internal]

Updates doxygen refid resolver to unmangle the template arguments.

Differential Revision: D94901504
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2026
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Mar 2, 2026
@meta-codesync
Copy link

meta-codesync bot commented Mar 2, 2026

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94901504.

@meta-codesync meta-codesync bot closed this in f018728 Mar 3, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 3, 2026
@meta-codesync
Copy link

meta-codesync bot commented Mar 3, 2026

This pull request has been merged in f018728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants