move DefaultTurboModules::get to end of TurboModuleManager#55852
Open
zeyap wants to merge 2 commits intofacebook:mainfrom
Open
move DefaultTurboModules::get to end of TurboModuleManager#55852zeyap wants to merge 2 commits intofacebook:mainfrom
zeyap wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Mar 2, 2026
…55852) Summary: ## Changelog: [General] [Changed] - move DefaultTurboModules::get to end of TurboModuleManager To align with android/ios; so that the logic before it can override default behavior Differential Revision: D94907092
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Mar 2, 2026
…55852) Summary: ## Changelog: [General] [Changed] - move DefaultTurboModules::get to end of TurboModuleManager To align with android/ios; so that the logic before it can override default behavior Differential Revision: D94907092
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Mar 2, 2026
…55852) Summary: Pull Request resolved: facebook#55852 ## Changelog: [General] [Changed] - move DefaultTurboModules::get to end of TurboModuleManager To align with android/ios; so that the logic before it can override default behavior Differential Revision: D94907092
Summary:
This is added so that one can easily enables c++ AnimatedModule in open source.
If an app doesn't use `RCTAnimatedModuleProvider`(ios) or `AnimatedCxxReactPackage`(android), it can fallback to this default AnimatedModule when it has both c++animated and shared backend enabled
- shared backend removes the need to pass down start/stop callbacks to NativeAnimatedNodesManagerProvider, so we can cleanly initialize it as static default
- RCTAnimatedModuleProvider uses the version of AnimatedModule that still relies on a dedicated CADisplayLink for start/stop
- AnimatedCxxReactPackage also bundles internal ViewEventModule (for NativeViewEvents) that shares `NativeAnimatedNodesManagerProvider` with AnimatedModule, but NativeViewEvents is not needed for open source
- Alternatively we could also expose `NativeAnimatedNodesManagerProvider` via UIManager so other turbomodules can also use it. However I don't think it makes sense to double down on another animation API on UIManager given we have shared backend.
- This assumes DefaultTurboModules is always the fallback module provider. So it'll not override when app already uses RCTAnimatedModuleProvider or AnimatedCxxReactPackage
## Changelog:
[General] [Added] - Add c++ AnimatedModule to DefaultTurboModules
Reviewed By: NickGerleman
Differential Revision: D94244698
…55852) Summary: ## Changelog: [General] [Changed] - move DefaultTurboModules::get to end of TurboModuleManager To align with android/ios; so that the logic before it can override default behavior Reviewed By: christophpurrer Differential Revision: D94907092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Changed] - move DefaultTurboModules::get to end of TurboModuleManager
To align with android/ios; so that the logic before it can override default behavior
Differential Revision: D94907092