Fix crash in RCTWebSocketModule when delegate callbacks fire after module invalidation#55858
Closed
lukeharvey wants to merge 1 commit intofacebook:mainfrom
Closed
Fix crash in RCTWebSocketModule when delegate callbacks fire after module invalidation#55858lukeharvey wants to merge 1 commit intofacebook:mainfrom
lukeharvey wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D95056045. |
Collaborator
|
This pull request was successfully merged by @lukeharvey in 587ef05 When will my fix make it into a release? | How to file a pick request? |
|
@cipolleschi merged this pull request in 587ef05. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Guard against nil socketID in all SRWebSocketDelegate callbacks in RCTWebSocketModule.
When the module is invalidated during teardown, invalidate nils the delegate and closes each socket. However, SocketRocket's network thread may have already dispatched a delegate callback to the main queue via setDelegateDispatchQueue:. By the time the block executes, the SRWebSocket has been deallocated and reactTag (an associated object) returns nil, causing either an objc_retain crash on a dangling pointer or an NSInvalidArgumentException when inserting nil into an NSDictionary literal.
The didFailWithError: callback already had a partial nil guard (socketID ?: @(-1)), but didCloseWithCode:, webSocketDidOpen:, and didReceiveMessage: did not. This adds consistent early-return nil checks to all four callbacks.
Previously reported in #28278, #29525, and #31048 — all closed by the stale bot without a fix being merged.
Changelog:
[IOS] [FIXED] - Fix crash in RCTWebSocketModule when delegate callbacks fire after module invalidation
Test Plan:
This is a race condition during module teardown that is difficult to reproduce deterministically — it surfaces in production Crashlytics reports (< 0.1% of sessions). The fix is a nil guard matching the defensive pattern already present in didFailWithError:.