Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D101247487. |
Summary: The recent introduction of the `IRuntime` JSI interface moved `ScopeState` from `Runtime` to `IRuntime`, changing the C++ ABI (mangled symbol names). The Android build was still consuming a legacy Hermes nightly (`hermes-compiler@nightly`) that was built against the old JSI headers, causing an `UnsatisfiedLinkError` crash at startup: ``` dlopen failed: cannot locate symbol "_ZN8facebook3jsi7Runtime8popScopeEPNS1_10ScopeStateE" referenced by "libhermesvm.so" ``` This PR aligns Android with how iOS already handles Hermes V1: 1. **`scripts/try-set-nightly-hermes-compiler.js`** — The `yarn install` preinstall hook now installs `hermes-compiler@latest-v1` instead of `hermes-compiler@nightly`. This is the same npm dist-tag that iOS uses in `scripts/ios-prebuild/hermes.js`. 2. **`build.gradle.kts`** — When `hermesV1Enabled=true`, the Hermes version from `package.json` is used as-is (no `-SNAPSHOT` suffix), since V1 stable releases are published as regular Maven artifacts, not snapshots. 3. **`version.properties`** — Bumps `HERMES_V1_VERSION_NAME` from `250829098.0.11` to `250829098.0.12` for release builds and iOS podspec. ## Changelog: [ANDROID] [FIXED] - Use Hermes V1 stable release instead of legacy nightly to fix startup crash caused by JSI ABI mismatch Test Plan: - Run `yarn install` from the repo root and verify `hermes-compiler` in `packages/react-native/package.json` is set to the `latest-v1` version (currently `250829098.0.12`) - Run `yarn android` from `packages/rn-tester` and verify the app launches without crashing - Verify CI `build_android` job passes Reviewed By: javache Differential Revision: D101247487 Pulled By: cipolleschi
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
cipolleschi/use-hermes-v1-by-default
branch
from
19cba09 to
c784ea8
Compare
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101247487. |
|
@cipolleschi merged this pull request in 45ceacc. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 45ceacc When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The recent introduction of the
IRuntimeJSI interface movedScopeStatefromRuntimetoIRuntime, changing the C++ ABI (mangled symbol names). The Android build was still consuming a legacy Hermes nightly (hermes-compiler@nightly) that was built against the old JSI headers, causing anUnsatisfiedLinkErrorcrash at startup:This PR aligns Android with how iOS already handles Hermes V1:
scripts/try-set-nightly-hermes-compiler.js— Theyarn installpreinstall hook now installshermes-compiler@latest-v1instead ofhermes-compiler@nightly. This is the same npm dist-tag that iOS uses inscripts/ios-prebuild/hermes.js.build.gradle.kts— WhenhermesV1Enabled=true, the Hermes version frompackage.jsonis used as-is (no-SNAPSHOTsuffix), since V1 stable releases are published as regular Maven artifacts, not snapshots.version.properties— BumpsHERMES_V1_VERSION_NAMEfrom250829098.0.11to250829098.0.12for release builds and iOS podspec.Changelog:
[ANDROID] [FIXED] - Use Hermes V1 stable release instead of legacy nightly to fix startup crash caused by JSI ABI mismatch
Test Plan:
yarn installfrom the repo root and verifyhermes-compilerinpackages/react-native/package.jsonis set to thelatest-v1version (currently250829098.0.12)yarn androidfrompackages/rn-testerand verify the app launches without crashingbuild_androidjob passesReviewed By: javache
Differential Revision: D101247487
Pulled By: cipolleschi