Fix unused parameter warnings in IMountingManager.h (#56488)#56488
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Fix unused parameter warnings in IMountingManager.h (#56488)#56488christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101110289. |
meta-codesync
bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
Summary: Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Differential Revision: D101110289
christophpurrer
force-pushed
the
export-D101110289
branch
from
0981aaa to
0eeef1a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
Summary: Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Differential Revision: D101110289
christophpurrer
force-pushed
the
export-D101110289
branch
from
0eeef1a to
fe56a70
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2026
Summary: Pull Request resolved: facebook#56488 Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Differential Revision: D101110289
christophpurrer
force-pushed
the
export-D101110289
branch
from
fe56a70 to
787ef0d
Compare
Summary: Pull Request resolved: facebook#56488 Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings. Changelog: [Internal] Differential Revision: D101110289
christophpurrer
force-pushed
the
export-D101110289
branch
from
787ef0d to
1d44db1
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 8944bb3 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 8944bb3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warnings in IMountingManager.h by commenting out parameter names while preserving types. This maintains API compatibility for virtual methods while eliminating lint warnings.
Changelog: [Internal]
Differential Revision: D101110289