Fix unused parameters in EventQueueProcessorTest.cpp (#56493)#56493
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Fix unused parameters in EventQueueProcessorTest.cpp (#56493)#56493christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101110552. |
Summary: Fixed clang-diagnostic-unused-parameter warnings in EventQueueProcessorTest.cpp by removing unused parameter names from lambda functions. Changes: - Line 51: Removed parameter name 'runtime' from dummyEventPipeConclusion lambda - Line 52: Removed parameter name 'stateUpdate' from dummyStatePipe lambda This is a standard C++ practice for handling unused parameters - keeping the type for API compatibility while removing the name to silence the warning. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D101110552
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D101110552
branch
from
25f2621 to
d3a5633
Compare
|
This pull request has been merged in acb85ce. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in acb85ce When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warnings in EventQueueProcessorTest.cpp by removing unused parameter names from lambda functions.
Changes:
This is a standard C++ practice for handling unused parameters - keeping the type for API compatibility while removing the name to silence the warning.
Changelog: [Internal]
Reviewed By: zeyap
Differential Revision: D101110552