fix(android): intercept ESCAPE key ACTION_DOWN in Modal to prevent premature dismiss

[taibin]

Summary

Fix Android Modal's handling of the ESCAPE key so that JavaScript is reliably notified (via onRequestClose) instead of the dialog dismissing itself before JS sees the event.

Problem

ReactModalHostView installs an OnKeyListener that only reacts on ACTION_UP for KEYCODE_BACK / KEYCODE_ESCAPE, calling handleCloseAction() to let JS decide whether to close.

However, Android's Dialog.onKeyDown() handles these two keys asymmetrically:

• KEYCODE_BACK — ACTION_DOWN only calls event.startTracking(); the dialog is dismissed on ACTION_UP via onBackPressed(). Our ACTION_UP interception works fine.
• KEYCODE_ESCAPE — ACTION_DOWN directly calls Dialog.cancel(). By the time our ACTION_UP handler would run, the dialog is already being dismissed, so onRequestClose is never delivered to JS.

Net effect: pressing ESCAPE on Android closes the Modal unconditionally, bypassing JS (breaks apps that rely on onRequestClose for confirmation dialogs, unsaved-changes prompts, etc.).

Fix

Restructure the key listener to branch on keyCode first:

• For KEYCODE_BACK / KEYCODE_ESCAPE:
  • Consume ACTION_DOWN (return true) to prevent Dialog.onKeyDown() from dismissing the dialog.
  • On ACTION_UP, call handleCloseAction() as before, giving JS the final say.
• For all other keys, preserve the previous behavior of forwarding ACTION_UP to the current Activity (needed by the dev menu, etc.).

Test Plan

• Render a <Modal visible> on Android, attach onRequestClose handler, press the hardware BACK button — handler fires, modal stays open unless JS sets visible={false}. (Regression coverage: unchanged behavior.)
• Same setup, press ESCAPE on a connected keyboard / emulator — handler now fires correctly; previously the modal closed without JS notification.
• Open the dev menu shortcut while a modal is not showing — still works (non-BACK/ESCAPE keys still forwarded to Activity).

Changelog

[ANDROID] [FIXED] - Modal's onRequestClose is now correctly invoked when pressing ESCAPE on Android (previously the dialog was dismissed before JS was notified).

[github-actions]

Caution

Missing Changelog

Please add a Changelog to your PR description. See Changelog format