Skip use-hermes-nightly when hermes-compiler is already pinned#56505
Closed
alanjhughes wants to merge 2 commits intomainfrom
Closed
Skip use-hermes-nightly when hermes-compiler is already pinned#56505alanjhughes wants to merge 2 commits intomainfrom
alanjhughes wants to merge 2 commits intomainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
cipolleschi
approved these changes
Apr 20, 2026
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D101633376. |
cortinico
approved these changes
Apr 20, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @alanjhughes in 70281d6 When will my fix make it into a release? | How to file a pick request? |
|
@cipolleschi merged this pull request in 70281d6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
use-hermes-nightlyunconditionally overwrites thehermes-compilerwith whatever thelatest-v1tag currently points to. On release branches, wherehermes-compileris pinned to a specific version, it replaces the pin. This doesn't cause an issue until thelatest-v1tag moves off the pinned version.Looks to have been introduced by #53837.
Changelog:
[INTERNAL] [FIXED] - Preserve pinned
hermes-compilerversion when runninguse-hermes-nightlyon release branches.Test Plan:
With
hermes-compilermanually set to a real version, the script returns early without modifyingpackage.jsonorhermes-engine/version.properties.