Extract RCTRedBoxController from RCTRedBox.mm#56509
Open
motiz88 wants to merge 3 commits intofacebook:mainfrom
Open
Extract RCTRedBoxController from RCTRedBox.mm#56509motiz88 wants to merge 3 commits intofacebook:mainfrom
motiz88 wants to merge 3 commits intofacebook:mainfrom
Conversation
Summary:
Here, we add a mechanism to override React Native feature flag default values via a Buck command line argument, without modifying source files.
A `genrule` in the featureflags BUCK target always interposes on `ReactNativeFeatureFlagsDefaults.h` before compilation. When `react_native.feature_flag_defaults` is set to a JSON object via `--config`, a Python script rewrites the return values in the matching method bodies. When unset, the header passes through unmodified.
The Python script matches each override against the full method signature shape (`<returnType> <flagName>() override { ... return <value>; }`) with lenient whitespace, and fails the build if any requested flag name is not found in the header.
Usage:
```
buck2 build --config 'react_native.feature_flag_defaults={"enableViewCulling":true}' //target
buck2 build --config 'react_native.feature_flag_defaults={"enableViewCulling":true,"preparedTextCacheSize":500}' //target
```
This modifies defaults only — app-level providers still take priority.
Changelog: [Internal]
Differential Revision: D101484355
Summary: Add `redBoxV2IOS` and `redBoxV2Android` common feature flags (default false), gating RedBox 2.0 independently on each platform. Changelog: [Internal] Differential Revision: D98115369
Summary: Moves the `RCTRedBoxController` class, previously inlined in `RCTRedBox.mm`, into its own implementation and header files (`RCTRedBoxController.mm`, `RCTRedBoxController+Internal.h`). An upcoming diff will fork these files for the experimental RedBox 2.0. Changelog: [Internal] Differential Revision: D101484586
meta-cla
bot
added
the
CLA Signed
|
@motiz88 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101484586. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the
RCTRedBoxControllerclass, previously inlined inRCTRedBox.mm, into its own implementation and header files (RCTRedBoxController.mm,RCTRedBoxController+Internal.h). An upcoming diff will fork these files for the experimental RedBox 2.0.Changelog: [Internal]
Differential Revision: D101484586