Skip to content

Enable overrideBySynchronousMountPropsAtMountingAndroid by default on Android #56652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jingjing2222 wants to merge 1 commit into from
Closed

Enable overrideBySynchronousMountPropsAtMountingAndroid by default on Android #56652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d2b14345bf627e35562530912b3aae1f>>
* @generated SignedSource<<a9a8ce443fa160a7494fc1c9e7baa02f>>
*/

/**
Expand Down Expand Up @@ -153,7 +153,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun hideOffscreenVirtualViewsOnIOS(): Boolean = false

override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false
override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = true

override fun perfIssuesEnabled(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<4a2fd61cbcdb28042f09ccb03c970674>>
* @generated SignedSource<<d987528598996fc7b1bf3c872f51e2ed>>
*/

/**
Expand Down Expand Up @@ -288,7 +288,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool overrideBySynchronousMountPropsAtMountingAndroid() override {
return false;
return true;
}

bool perfIssuesEnabled() override {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
overrideBySynchronousMountPropsAtMountingAndroid: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2025-09-04',
description:
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<aa202d346e68c3dd641d557306964ebe>>
* @generated SignedSource<<1dd51a152bb30c0e2073a14566c8368d>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -468,7 +468,7 @@ export const hideOffscreenVirtualViewsOnIOS: Getter<boolean> = createNativeFlagG
/**
* Override props at mounting with synchronously mounted (i.e. direct manipulation) props from Native Animated.
*/
export const overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean> = createNativeFlagGetter('overrideBySynchronousMountPropsAtMountingAndroid', false);
export const overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean> = createNativeFlagGetter('overrideBySynchronousMountPropsAtMountingAndroid', true);
/**
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
*/
Expand Down
Loading