[compiler] Fix Symbol shadowing in generated code #35429
Closed
+569
−560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35379
When a component is named
Symbol, it shadows the globalSymbolobject. The compiler currently emitsSymbol.for("react.memo_cache_sentinel")for memoization checks, which breaks at runtime because it tries to call.for()on the React component instead of the global Symbol.This changes the codegen to use
globalThis.Symbol.for()instead, which works regardless of local shadowing. The same fix is applied to the runtime package.How did you test this change?
Updated the test fixtures to verify the new output format. The generated code now uses:
This matches the approach used in Babel's own codebase (see babel/babel#3250) where they had the same shadowing issue.