Conversation
- Removed items in the `pointStatistic.ts` module and placed them in other modules for better structure. Updated all modules that needed to be updated due to the move. - Moved the method `updateAxisLabel` to a new module called `utils/plottingUtils.ts` for reuse. - Significantly reduced the complexity in `webpack.config.js` and `tsconfig.json`. - Updated the `viz.py` file to include the new marginal 2d tool. - Added the marginal 2d tool.
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Looks like there're some version updates in Our internal jobs currently fails because it cannot find the node modules that are being used, so I just want to check with you to see if the versions that were in |
|
This is totally my mistake. I was trying out Bokeh 3.0 and did an update with yarn, which is why the lock file changed. I completely forgot to recheckout the lock file and not commit the changes. I'll revert now those changes. |
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Motivation
Continued work on the diagnostics tools.
Changes proposed
pointStatistic.tsmodule and placed them in other modules for better structure. Updated all modules that needed to be updated due to the move.updateAxisLabelto a new module calledutils/plottingUtils.tsfor reuse.webpack.config.jsandtsconfig.json.viz.pyfile to include the new marginal 2d tool.Test Plan
Just visual inspection for now, test to come soon.
Types of changes
Checklist