allow skipping extras_requires from (Build)Requires#213
Open
evgeni wants to merge 3 commits intofedora-python:mainfrom
Open
allow skipping extras_requires from (Build)Requires#213evgeni wants to merge 3 commits intofedora-python:mainfrom
evgeni wants to merge 3 commits intofedora-python:mainfrom
Conversation
Member
|
Glancing over this, the only thing that stands out is that there are no tests. Could you identify a module that has extra requires and include a test case with and without them? |
Author
|
Yes, I will add tests this week. |
evgeni
force-pushed
the
include_extras
branch
from
d9dd51e to
be833c7
Compare
Author
|
@gordonmessmer how is this? I've only added tests for runtime deps as that's what I had at hand in a package of mine. Should I search for a package that does the same in build deps? |
Author
|
nvm, found one |
sometimes one wants to generate a "minimal" RPM, with no extra dependencies, which this should help with.
evgeni
force-pushed
the
include_extras
branch
from
f536fc4 to
1e55551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sometimes one wants to generate a "minimal" RPM, with no extra
dependencies, which this should help with.