Add --incompatible_allow_status_files_without_stamp (fixes #14341)#9
Closed
alexeagle wants to merge 2 commits into
Closed
Add --incompatible_allow_status_files_without_stamp (fixes #14341)#9alexeagle wants to merge 2 commits into
alexeagle wants to merge 2 commits into
Conversation
Fixes bazelbuild#14341 by introducing --incompatible_allow_status_files_without_stamp (default true) so rule authors can opt into requiring stamp/--stamp before ctx.info_file and ctx.version_file are available.
Use --incompatible_prevent_status_files_without_stamp (default false) per Bazel breaking-change guidance, and add a test for stamp transitions on dependency edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--incompatible_allow_status_files_without_stamp(defaulttrue) to control access toctx.info_file,ctx.version_file, and the correspondingctx.actions.transform_*_fileAPIs.stampattribute or--stamp); otherwise analysis fails with an error pointing at the rule implementation.Test plan
bazel test //src/test/java/com/google/devtools/build/lib/starlark:StarlarkTests --test_filter=infoFile_*src/test/shell/bazel/bazel_workspace_status_test.sh(specificallytest_allow_status_files_without_stamp)ctx.info_filewithout--stamp--noincompatible_allow_status_files_without_stampfails unstamped rules and succeeds with--stamp