Skip to content

Add Node 24 to build matrix#18

Draft
dmartin-figma wants to merge 10 commits intofigma:figmafrom
dmartin-figma:dmartin/add-node-24
Draft

Add Node 24 to build matrix#18
dmartin-figma wants to merge 10 commits intofigma:figmafrom
dmartin-figma:dmartin/add-node-24

Conversation

@dmartin-figma
Copy link
Copy Markdown

Summary

Adds Node 24 to the Linux + macOS test/publish matrix so subsequent v0.28.0-figma.* tag pushes also produce ABI v137 prebuilt binaries (alongside existing 108/115/127).

Why

The internal-agents Cursor pods at Figma run on Node 24 (/opt/cursor-agent/node is v24.5.0, ABI v137), bundled with the Cursor agent runtime. The bucket policy and per-object ACLs are already correct — the underlying issue surfaced as a 403 on https://figma-nodegit.s3.amazonaws.com/nodegit-v0.28.0-figma.9-node-v137-linux-x64.tar.gz because the v137 object simply doesn't exist (S3 returns AccessDenied to anonymous clients without s3:ListBucket for missing keys, masking it as a permissions issue). Confirmed via aws s3api get-object-acl from a readonly role → NoSuchKey. The bucket has no v131 or v137 objects, ever.

This duplicates the intent of the now-stale #14, which proposed [20, 22, 24] (dropped 18). Closed without comment 2026-03-28. This PR keeps 18 in for backwards compatibility and only adds 24, so it's strictly additive.

Test plan

  • CI (Linux + macOS) green on Node 24
  • After merge, cut a new tag v0.28.0-figma.11 to trigger a publish — the resulting nodegit-v0.28.0-figma.11-node-v137-{linux-x64,darwin-arm64}.tar.gz objects should land in s3://figma-nodegit/
  • Cursor agent pnpm install no longer fails on @figma/nodegit after consumers bump to figma.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant