Skip to content

Conversation

@coopernetes
Copy link
Contributor

@coopernetes coopernetes commented Feb 9, 2026

Move developer resources (setup, building, testing, code quality) into
CONTRIBUTING.md and refocus the website's contributing page on project
governance (roles, voting, CLA). Slim down localgit/README.md to a
summary now that CONTRIBUTING.md covers E2E setup in detail.

Rename E2E test repositories from real project names to clearly fake
names (test-owner/test-repo, e2e-org/sample-repo). Add fail-fast
pre-flight checks in E2E setup to detect missing Docker infrastructure.
Add Docker Hub login to CI workflow to avoid pull rate limits. Remove
outdated Mocha/Chai testing page from docs site and fix plugin import
paths.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 9, 2026
@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit f0c0e57
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/698b77546f826a0008c50522

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.34%. Comparing base (6fb63d0) to head (f0c0e57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          65       65           
  Lines        4648     4648           
  Branches      792      792           
=======================================
  Hits         3781     3781           
  Misses        852      852           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coopernetes
Copy link
Contributor Author

@jescalada @kriswest this PR points out the challenges with running these types of tests from a forked PR. Note that e2e.yml workflow is never fired since it's trigger is on pull_request, not pull_request_target.
The latter trigger, which would run the e2e job from a fork, has many documented security problems so it is unsafe to provide access to credentials such as Docker Hub via those jobs.

I'm unsure how to most effectively test these changes other than checking out to a local branch on the repo and re-running the checks in an unrelated PR and referencing those checks in this one.

@coopernetes
Copy link
Contributor Author

Should probably be merged after #1391 and #1385

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 9, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: coopernetes / name: Thomas Cooper (f0c0e57)

@coopernetes coopernetes force-pushed the docs/contrib-fixup branch 3 times, most recently from d4ca134 to 0666146 Compare February 10, 2026 17:57
Move developer resources (setup, building, testing, code quality) into
CONTRIBUTING.md and refocus the website's contributing page on project
governance (roles, voting, CLA). Slim down localgit/README.md to a
summary now that CONTRIBUTING.md covers E2E setup in detail.

Rename E2E test repositories from real project names to clearly fake
names (test-owner/test-repo, e2e-org/sample-repo). Add fail-fast
pre-flight checks in E2E setup to detect missing Docker infrastructure.
Add Docker Hub login to CI workflow to avoid pull rate limits. Remove
outdated Mocha/Chai testing page from docs site and fix plugin import
paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant