-
Notifications
You must be signed in to change notification settings - Fork 154
docs: restructure contributing docs and improve E2E test infrastructure #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 65 65
Lines 4648 4648
Branches 792 792
=======================================
Hits 3781 3781
Misses 852 852
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jescalada @kriswest this PR points out the challenges with running these types of tests from a forked PR. Note that e2e.yml workflow is never fired since it's trigger is on I'm unsure how to most effectively test these changes other than checking out to a local branch on the repo and re-running the checks in an unrelated PR and referencing those checks in this one. |
666d7ab to
947ca46
Compare
947ca46 to
5756067
Compare
|
|
d4ca134 to
0666146
Compare
Move developer resources (setup, building, testing, code quality) into CONTRIBUTING.md and refocus the website's contributing page on project governance (roles, voting, CLA). Slim down localgit/README.md to a summary now that CONTRIBUTING.md covers E2E setup in detail. Rename E2E test repositories from real project names to clearly fake names (test-owner/test-repo, e2e-org/sample-repo). Add fail-fast pre-flight checks in E2E setup to detect missing Docker infrastructure. Add Docker Hub login to CI workflow to avoid pull rate limits. Remove outdated Mocha/Chai testing page from docs site and fix plugin import paths.
0666146 to
f0c0e57
Compare
Move developer resources (setup, building, testing, code quality) into
CONTRIBUTING.md and refocus the website's contributing page on project
governance (roles, voting, CLA). Slim down localgit/README.md to a
summary now that CONTRIBUTING.md covers E2E setup in detail.
Rename E2E test repositories from real project names to clearly fake
names (test-owner/test-repo, e2e-org/sample-repo). Add fail-fast
pre-flight checks in E2E setup to detect missing Docker infrastructure.
Add Docker Hub login to CI workflow to avoid pull rate limits. Remove
outdated Mocha/Chai testing page from docs site and fix plugin import
paths.