Skip to content

Update changelog#10316

Open
wandamora wants to merge 2 commits intomainfrom
wm-add-changelog
Open

Update changelog#10316
wandamora wants to merge 2 commits intomainfrom
wm-add-changelog

Conversation

@wandamora
Copy link
Copy Markdown
Contributor

Update changelog for internal fixes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a vague entry to the changelog regarding internal fixes. Feedback was provided to either remove the entry if the changes are not user-facing or to provide a more descriptive summary as per the repository's style guide.

CHANGELOG.md Outdated
@@ -0,0 +1 @@
- Internal fixes No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog entry '- Internal fixes' is vague. Per the repository's style guide (GEMINI.md, line 58), the changelog is intended for user-facing changes. If these fixes are purely internal and do not affect the user, this entry should be removed. If they are user-facing, please provide a more descriptive summary of the changes so users can understand the impact.

References
  1. Changelog entries should be added for user-facing changes (new features, bug fixes, deprecations). (link)

Copy link
Copy Markdown
Contributor

@shettyvarun268 shettyvarun268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Might have to fix the lint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants