fix(macos): drop Event::Empty arm in demangle_stream that corrupted x…#446
Merged
djc merged 1 commit intoflamegraph-rs:mainfrom Apr 20, 2026
Merged
Conversation
…ctrace XML The Event::Empty arm (self-closing tags like <binary .../>) was matched to 'start' and then written as Event::Start without a corresponding closing tag, producing malformed XML that broke inferno's xctrace collapser with IllFormed(MismatchedEndTag). This broke profiling of C++ binaries on macOS.
djc
approved these changes
Apr 20, 2026
Contributor
|
Sounds good, thanks. How hard would it be to have a (smallish) sample XML file in the repo to exercise this code against? |
Contributor
Author
|
Should be easy, i'll provide file soon but whether it needs some CI hooking into is a mystery to me |
Contributor
If you can just submit a PR with a unit test that would be great. |
|
Thanks, seems to have fixed things for me too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Event::Empty arm (self-closing tags like <binary .../>) was matched to 'start' and then written as Event::Start without a corresponding closing tag, producing malformed XML that broke inferno's xctrace collapser with IllFormed(MismatchedEndTag).
This broke profiling of C++ binaries on macOS.
This should fix #445
Ive tested this with c++ and rust binaries but please lmk if more coverage would help