Skip to content

Conversation

@osantana85
Copy link
Member

No description provided.

@osantana85 osantana85 requested a review from dieppa December 27, 2025 14:05
Copy link
Member

@dieppa dieppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good.
MongoDBTargetSystemInitiative makes sense here, but MongoDatabaseAccessor isn’t needed in this case. I assume you added it to avoid propagating the wrong ReadConcern, WriteConcern, and ReadPreference. However, the audit store collections are created using the settings from the actual auditStore, and those take precedence over any database defaults, so this is safe.

That means we can use the database directly in the targetSystem, which is fine. The only constraint is that the TargetSystem must be initialized before the AuditStore. That’s a logical rule we can (and should) enforce.

To do that, we need to update AbstractBuilder.configureStoreAndTargetSystem:L84 so the initialization order guarantees this (it’s currently the other way around).

@dieppa dieppa merged commit c419673 into develop Dec 30, 2025
4 checks passed
@dieppa dieppa deleted the refactor/mongodb-target-system-api branch February 9, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants