DCAP attestation: Add GCP provenence check to establish whether the associated PPID is endorsed by Google#54
Open
ameba23 wants to merge 13 commits into
Open
DCAP attestation: Add GCP provenence check to establish whether the associated PPID is endorsed by Google#54ameba23 wants to merge 13 commits into
ameba23 wants to merge 13 commits into
Conversation
* main: Bump reqwest to 0.13.4 chore(deps): bump openssl from 0.10.79 to 0.10.80
ameba23
commented
Jul 6, 2026
| expected_input_data: [u8; 64], | ||
| pccs: Option<Pccs>, | ||
| ) -> Result<MultiMeasurements, DcapVerificationError> { | ||
| ) -> Result<(MultiMeasurements, Quote), DcapVerificationError> { |
Collaborator
Author
There was a problem hiding this comment.
To avoid parsing the quote a second time to extract the PPID after verification, the verifier function now returns the parsed quote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will not yet work, but is in anticipation of GCP publicly publishing PPIDs of their TDX machines. Do not merge until this is available and has been tested in production.
When verifying an attestation which claims to be of type
AttestationType::GcpTdxthis PR adds an additional check as to whether the PPID from the PCK certificate included in the attestation is present in GCP's [soon to be] public bucket, which indicates that the PPID belongs to them.To avoid unnecessary network calls on subsequent verifications, known GCP PPIDs are cached for up to one week. We might want to make this cache time shorter.
TODO:
.jsonsuffix when building the URL? The Go implementation has it: https://github.com/google/go-tdx-guest/blob/34f07ec666c41a9b6f17fd36d507d8d9f7adcf7b/tools/provenance/main.go#L113 but its not mentioned in the doc they shared. Easy to check once the bucket is made public.